Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt close-hovering icon for notification API #2048

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Jul 6, 2024

The close icon for showing notifications has been adapted with a more modern look and feel. The "active" version of the icon, used when hovering over it, is currently still the old one and does not fit the new icon anymore.

This change introduces a new "active" version of the notification close icon, being a thicker version of the non-active one.

Fixes #2043

How it looks like

notification_close_active_new

PR for images repo

Here is the according PR for the images repo: eclipse-platform/eclipse.platform.images#82

The close icon for showing notifications has been adapted with a more
modern look and feel. The "active" version of the icon, used when
hovering over it, is currently still the old one and does not fit the
new icon anymore.

This change introduces a new "active" version of the notification close
icon, being a thicker version of the non-active one.

Fixes eclipse-platform#2043
HeikoKlare added a commit to HeikoKlare/eclipse.platform.images that referenced this pull request Jul 6, 2024
Updates the icons used by JFace notifications. Also removes the (unused
and equal) disabled version of the icons.

See eclipse-platform/eclipse.platform.ui#2037
See eclipse-platform/eclipse.platform.ui#2048
@HeikoKlare
Copy link
Contributor Author

@vogella @BeckerWdf may I ask you for feedback on this? Do you consider this is proper and intuitive way of providing hovering feedback (in the context of such a popup)?

@HeikoKlare HeikoKlare marked this pull request as ready for review July 6, 2024 11:15
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 29m 19s ⏱️ - 2m 43s
 7 663 tests ±0   7 435 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 150 runs  ±0  23 401 ✅ +1  749 💤 ±0  0 ❌  - 1 

Results for commit 858c0ec. ± Comparison against base commit 44dc49e.

@BeckerWdf
Copy link
Contributor

@vogella @BeckerWdf may I ask you for feedback on this? Do you consider this is proper and intuitive way of providing hovering feedback (in the context of such a popup)?

I like it!! 👍

@vogella
Copy link
Contributor

vogella commented Jul 7, 2024

Perfect, thanks for this.

@HeikoKlare
Copy link
Contributor Author

Thanks for your feedback! Then I'll merge this together with the images repo PR eclipse-platform/eclipse.platform.images#82

Since it's only an icon exchange, I do not rebase on master and trigger an unnecessary build before merging.

@HeikoKlare HeikoKlare merged commit 991408d into eclipse-platform:master Jul 7, 2024
16 checks passed
@HeikoKlare HeikoKlare deleted the issue-2043 branch July 7, 2024 11:19
HeikoKlare added a commit to eclipse-platform/eclipse.platform.images that referenced this pull request Jul 7, 2024
Updates the icons used by JFace notifications. Also removes the (unused
and equal) disabled version of the icons.

See eclipse-platform/eclipse.platform.ui#2037
See eclipse-platform/eclipse.platform.ui#2048
@vogella
Copy link
Contributor

vogella commented Jul 7, 2024

Thanks @HeikoKlare re for this work (including providing the icon). I hope that we will see the notification API used more often in the future. For example, the restart dialog after an installation operation might be a good candidate for non-blocking notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification-Overlay: old x-icon is shown when I hover over the new x
3 participants