-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt close-hovering icon for notification API #2048
Conversation
The close icon for showing notifications has been adapted with a more modern look and feel. The "active" version of the icon, used when hovering over it, is currently still the old one and does not fit the new icon anymore. This change introduces a new "active" version of the notification close icon, being a thicker version of the non-active one. Fixes eclipse-platform#2043
Updates the icons used by JFace notifications. Also removes the (unused and equal) disabled version of the icons. See eclipse-platform/eclipse.platform.ui#2037 See eclipse-platform/eclipse.platform.ui#2048
@vogella @BeckerWdf may I ask you for feedback on this? Do you consider this is proper and intuitive way of providing hovering feedback (in the context of such a popup)? |
I like it!! 👍 |
Perfect, thanks for this. |
Thanks for your feedback! Then I'll merge this together with the images repo PR eclipse-platform/eclipse.platform.images#82 Since it's only an icon exchange, I do not rebase on master and trigger an unnecessary build before merging. |
Updates the icons used by JFace notifications. Also removes the (unused and equal) disabled version of the icons. See eclipse-platform/eclipse.platform.ui#2037 See eclipse-platform/eclipse.platform.ui#2048
Thanks @HeikoKlare re for this work (including providing the icon). I hope that we will see the notification API used more often in the future. For example, the restart dialog after an installation operation might be a good candidate for non-blocking notification. |
The close icon for showing notifications has been adapted with a more modern look and feel. The "active" version of the icon, used when hovering over it, is currently still the old one and does not fit the new icon anymore.
This change introduces a new "active" version of the notification close icon, being a thicker version of the non-active one.
Fixes #2043
How it looks like
PR for images repo
Here is the according PR for the images repo: eclipse-platform/eclipse.platform.images#82