Find/Replace: streamline editability checking and improve tests #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
findreplace-streamline-editability
branch
from
11c7454 to
c7b09fc
Compare
HeikoKlare
force-pushed
the
findreplace-streamline-editability
branch
from
c7b09fc to
f72766a
Compare
The logic for checking editability of the target of a FindReplaceOverlay is slightly scattered, resulting in not being capable of dealing with a change in the editability of the target editor. This change streamlines the editability checking by dynamically adapting visibility replace-related widgets visibility instead of static (non-)creation of the widget. To test this functionality, the test classes for the FindReplaceDialog and FindReplaceOverlay are adapted to properly reuse a FindReplaceAction once instantiated for a target instead of recreating it.
HeikoKlare
force-pushed
the
findreplace-streamline-editability
branch
from
f72766a to
feb50d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for checking editability of the target of a FindReplaceOverlay is slightly scattered, resulting in not being capable of dealing with a change in the editability of the target editor.
This change streamlines the editability checking by dynamically adapting visibility replace-related widgets visibility instead of static (non-)creation of the widget.
To test this functionality, the test classes for the FindReplaceDialog and FindReplaceOverlay are adapted to properly reuse a FindReplaceAction once instantiated for a target instead of recreating it.