Do not unhide find/replace overlay of other editors when resizing #2059 #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
issue-2059
branch
2 times, most recently
from
e9f0314 to
dbab727
Compare
…ipse-platform#2059 When multiple editors have an open find/replace overlay and a resize event happens (e.g., by minimizing/maximizing the window), the overlays of all editors are unhidden by accident. This was a result of introducing hide functionality to the overlay for the case that the target editor is too small to show the overlay, which conflicts with the hiding functionality for the case that an editor is invisible. This change streamlines the visibility-related functionality of the find/replace overlay to be handled at a single place. In addition, all repositioning and resizing events are only processed when an overlay is actually visible. For invisible overlays, the repositioning and resizing is now performed when they become visible again. In addition, a unnecessary layouting and positionining operations when creating the overlay are removed as the same operations are performed again when opening the overlay anyway. Fixes eclipse-platform#2059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple editors have an open find/replace overlay and a resize event happens (e.g., by minimizing/maximizing the window), the overlays of all editors are unhidden by accident. This was a result of introducing hide functionality to the overlay for the case that the target editor is too small to show the overlay, which conflicts with the hiding functionality for the case that an editor is invisible.
This change streamlines the visibility-related functionality of the find/replace overlay to be handled at a single place. In addition, all repositioning and resizing events are only processed when an overlay is actually visible. For invisible overlays, the repositioning and resizing is now performed when they become visible again. In addition, a unnecessary layouting and positionining operations when creating the overlay are removed as the same operations are performed again when opening the overlay anyway.
Fixes #2059