Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTMLPrinter.insertPageProlog(StringBuffer, int, RGB, RGB, String) #2070

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix HTMLPrinter.insertPageProlog(StringBuffer, int, RGB, RGB, String) #2070

merged 1 commit into from
Jul 10, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 10, 2024

  • The implementation uses the fgRGB where it should be using the bgRGB instead.

@merks
Fix HTMLPrinter.insertPageProlog(StringBuffer, int, RGB, RGB, String)
68d03cc 
- The implementation uses the fgRGB where it should be using the bgRGB
instead.
@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 34m 51s ⏱️ +47s
 7 665 tests ±0   7 437 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 156 runs  ±0  23 407 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 68d03cc. ± Comparison against base commit 21f5812.

@merks merks merged commit 43df788 into eclipse-platform:master Jul 10, 2024
15 of 16 checks passed
@merks merks deleted the pr-HTMLPrinter.insertPageProlog branch July 10, 2024 13:36
@BeckerWdf
Copy link
Contributor

good catch

@merks
Copy link
Contributor Author

merks commented Jul 10, 2024

Black text on a black ground is really the ultimate darkest dark theme. 😱

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merks @BeckerWdf