Increase left margins in F&R overlay #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for the error icon to appear completely when necessary e.g. when searching for an invalid regular expression.
|
How does this look without the icons? |
Test Results 1 818 files ±0 1 818 suites ±0 1h 32m 51s ⏱️ + 2m 41s For more details on these failures, see this check. Results for commit a9746d2. ± Comparison against base commit 7587ea1. |
Like this:
Why do you ask? Did I miss anything? |
|
Failing test is unrelated #195 |
Now we have quite a large whitespace to the left of the input field, just because of the (seldom) use case of having an invalid regex entered. Isn't there any other solution to the problem than this tweak? |
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the error icon to appear completely when necessary e.g. when searching for an invalid regular expression.
Before this PR
The error icon is cut on the left:
After this PR