New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the classes with shortcut #2413

Closed

jannisCode wants to merge 0 commits into eclipse-platform:master from jannisCode:tab_change

Contributor

jannisCode commented Oct 17, 2024 •

edited

Loading

This PR finishes the PR started by @Wittmaxi , who also did most of the work here: #1874
The objective of @Wittmaxi ´s PR is to be able to expand the functionality of the nextTab shortcut (default crtl + pgdown) so that after reaching the last tab, one more click changes the active tab back to the first one.

What this PR does

When there are too many tabs open, #1874 still went back to the first tab, ignoring the remaining tabs stored in the chevron (the >> container).

With the changes from this PR, when there are stored tabs in the chevron, clicking once more after the last tab has the same functionality as the default eclipse, going into the chevron.

tabaction.mp4

jannisCode force-pushed the tab_change branch 4 times, most recently from 21d07b3 to 402bd75 Compare

October 17, 2024 08:53

Contributor

github-actions bot commented Oct 17, 2024 •

edited

Loading

Test Results

1 821 files ±0 1 821 suites ±0 1h 52m 18s ⏱️ + 6m 53s
7 724 tests ±0 7 495 ✅ ±0 228 💤 ±0 1 ❌ ±0
24 333 runs ±0 23 585 ✅ ±0 747 💤 ±0 1 ❌ ±0

For more details on these failures, see this check.

Results for commit 473cefe. ± Comparison against base commit 136afb4.

♻️ This comment has been updated with latest results.

Wittmaxi requested changes

View reviewed changes

Wittmaxi left a comment

Small nitpicks. I can check functionality later and merge if it works

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              	 *
+              	 * @param folder
+              	 * @return if there are any items which are not shown in the folder (tabs in the
+              	 *         >> column)

Wittmaxi Oct 17, 2024

the ">> column" is called "the chevron"

Wittmaxi Oct 17, 2024

https://ux.stackexchange.com/questions/105135/difference-between-caret-and-chevron

Contributor Author

jannisCode Oct 17, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              	/**
+              	 * checks if there are any hidden items
+              	 *
+              	 * @param folder

Wittmaxi Oct 17, 2024

please describe further

Contributor Author

jannisCode Oct 17, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              	 *         >> column)
+              	 */
+              	private boolean areHiddenItems(CTabFolder folder) {
+              		for (CTabItem i : folder.getItems()) {

Wittmaxi Oct 17, 2024

Use https://www.geeksforgeeks.org/stream-anymatch-java-examples/

Contributor Author

jannisCode Oct 17, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              	/**
+              	 * Sets the current selection to the second-to-last item in the given direction.
+              	 *
+              	 * @param folder

Wittmaxi Oct 17, 2024

describe folder and forward

Contributor Author

jannisCode Oct 17, 2024

done

jannisCode force-pushed the tab_change branch 10 times, most recently from e40fc60 to bb64c62 Compare

October 22, 2024 14:02

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

66be584

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from bb64c62 to 66be584 Compare

October 23, 2024 09:39

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

9a98ff4

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 66be584 to 9a98ff4 Compare

October 25, 2024 07:54

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

867d55e

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 9a98ff4 to 867d55e Compare

October 25, 2024 12:28

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

89130d3

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 867d55e to 89130d3 Compare

October 28, 2024 10:01

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 89130d3 to 9553700 Compare

November 5, 2024 13:15

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

473cefe

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 9553700 to 473cefe Compare

November 5, 2024 16:33

jannisCode marked this pull request as ready for review

November 5, 2024 16:33

Wittmaxi requested changes

View reviewed changes

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

		Control control = focusControl;

Wittmaxi Nov 14, 2024

empty diff

Contributor Author

jannisCode Nov 19, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

               			do {
+              				if (control instanceof CTabFolder folder && isFinalItemInCTabFolder(folder, forward)
+              						&& !areHiddenItems(folder)) {
+              					loopToSecondToFirstItemInCTabFolder(folder, forward);

Wittmaxi Nov 14, 2024

"loopToSecondToFirstItemInCTabFolder" is not a desirable name. Are you referring to the "second to last" item or to the "second" item?

Contributor Author

jannisCode Nov 19, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              		}
+              		return false;
+              	}

Wittmaxi Nov 14, 2024

by convention, please add a line here

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

               		return null;
               	}
+              	private boolean areHiddenItems(CTabFolder folder) {
+              		CTabItem[] items = folder.getItems();
+              		for (CTabItem i : items) {

Wittmaxi Nov 14, 2024

use this https://stackoverflow.com/questions/31419931/how-do-you-check-if-a-list-contains-an-element-that-matches-some-predicate

Contributor Author

jannisCode Nov 19, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

@@ @@ -70,5 +124,4 @@ protected Method getMethodToExecute() { @@
               		}
               		return null;
               	}
-              }
+              }

Wittmaxi Nov 14, 2024

please keep the diff clean

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              		}
+              	}
+              	/**https://github.com/jannisCode/eclipse.jdt.ui.git

Wittmaxi Nov 14, 2024

By convention, the first line of javadoc comments is empty (atleast that's what I have seen everywhere else)

Contributor Author

jannisCode Nov 19, 2024

done

...rg.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java Outdated

+              	}
+              	/**
+              	 * Sets the current selection to the second-to-last item in the given direction.

Wittmaxi Nov 14, 2024

second to last? or second to first?

Contributor Author

jannisCode Nov 19, 2024

done

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

575359a

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 473cefe to 575359a Compare

November 19, 2024 08:43

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

9bc6fff

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch from 575359a to 9bc6fff Compare

November 19, 2024 08:45

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

3e7bafa

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

eclipse-platform#2413

jannisCode force-pushed the tab_change branch 2 times, most recently from 3e7bafa to aa3f7d1 Compare

November 19, 2024 09:36

jannisCode closed this

jannisCode force-pushed the tab_change branch from aa3f7d1 to 69f6e45 Compare

November 19, 2024 09:37

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

905ac0b

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode mentioned this pull request

Change classes with shortcut #2523

Open

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

8f531f8

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

f16f503

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

ecd36ed

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

d478459

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

7b53e93

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

b5860be

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

f29e611

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

9ec13da

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

ddb696f

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

jannisCode added a commit to jannisCode/eclipse.platform.ui that referenced this pull request


          Change classes with shortcut eclipse-platform#2413

fe4839f

Tab change can now handle the chevron. And after reaching the last tab,
it jumps to the first, if chevron doesn´t exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet