WorkbenchServiceRegistry: Use generics instead of raw types #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce ecj warnings
|
CI unrelated random fail #80 |
BeckerWdf
reviewed
Jun 20, 2023
|
|
||
| static class ServiceFactoryHandle { | ||
| AbstractServiceFactory factory; | ||
| WeakHashMap serviceLocators = new WeakHashMap(); |
There was a problem hiding this comment.
was there a good reason to use WeakHashMap instead of a Set?
There was a problem hiding this comment.
i don't know. As the Name says it is weak -i.e. it can be GCed. probably on purpose
There was a problem hiding this comment.
And now it can't be GCed any more. Is that an issue?
There was a problem hiding this comment.
why could'nt it? its still a WeakHashMap under the hood
There was a problem hiding this comment.
Ah. Sure. I didn't see that. Sorry for the confusion.
BeckerWdf
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce ecj warnings