Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1668] API types to simplify work with launch configuration attributes #1669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ruspl-afed
Copy link
Contributor

  • identify launch attribute
  • connect it with preference metadata (to supply defaults/label/description)
  • read attribute from configuration
  • write attribute to configuration working copy

ruspl-afed and others added 2 commits December 19, 2024 18:18
…uration attributes

* identify launch attribute
* connect it with preference metadata (to supply
defaults/label/description)
* read attribute from configuration
* write attribute to configuration working copy
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 59da2990264a1f97068a1cc1c145badc3086d86f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 19 Dec 2024 15:23:10 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/debug/org.eclipse.debug.core/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.core/META-INF/MANIFEST.MF
index e797ed2fe6..cdd768c6fb 100644
--- a/debug/org.eclipse.debug.core/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.core; singleton:=true
-Bundle-Version: 3.22.0.qualifier
+Bundle-Version: 3.22.100.qualifier
 Bundle-Activator: org.eclipse.debug.core.DebugPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 668 files   -    87   1 668 suites   - 87   1h 14m 32s ⏱️ - 13m 37s
 3 573 tests  -   597   3 552 ✅  -   596   21 💤  - 1  0 ❌ ±0 
11 316 runs   - 1 791  11 157 ✅  - 1 786  159 💤  - 5  0 ❌ ±0 

Results for commit 02d2400. ± Comparison against base commit ca5ed8a.

This pull request removes 597 tests.
AllTests ApiDocTest ‑ testTopicsReference
AllTests LinkTest ‑ testAllLinks
AllTests TocLinkChecker ‑ testJdtIsvGenerated
AllTests TocLinkChecker ‑ testJdtIsvStatic
AllTests TocLinkChecker ‑ testJdtUser
AllTests TocLinkChecker ‑ testPdeUserGenerated
AllTests TocLinkChecker ‑ testPdeUserStatic
AllTests TocLinkChecker ‑ testPlatformIsvGenerated
AllTests TocLinkChecker ‑ testPlatformIsvStatic
AllTests TocLinkChecker ‑ testPlatformUser
…

@mickaelistria
Copy link
Contributor

As mentioned in the call, some example using this API proposal would be helpful. There is probably some content in org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/launchConfigurations you can tweak to leverage this API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants