GH-5148 Introduce "soft fail" for corrupt ValueStore #5150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5148
Briefly describe the changes proposed in this PR:
ValueStore.data2value()
with SailException (previously it was possible to get anArrayIndexOutOfBoundsException
andIllegalArgumentException
).org.eclipse.rdf4j.sail.nativerdf.softFailOnCorruptData
to enable "soft failure mode" and to avoid exceptions as described above. Instead, an instance of the newly introduced CorruptValue will be returned.RepositoryConnection
would be forcefully closed when hitting the first corrupted value.PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)