GH-5210 Enable implementing sails to benefit from parent sail buffering #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmottestad
requested changes
Dec 21, 2024
| @@ -973,6 +971,13 @@ protected void prepareInternal() throws SailException { | |||
| protected abstract void addStatementInternal(Resource subj, IRI pred, Value obj, Resource... contexts) | |||
| throws SailException; | |||
|
|
|||
| protected void bulkAddStatementsInternal(final Collection<? extends Statement> statements) | |||
There was a problem hiding this comment.
Could you annotate this with @experimental so that we can adjust the signature down the line if we need to?
benherber
force-pushed
the
GH-5210-bulk-flush-to-child-sail
branch
from
9034649 to
43064ff
Compare
… sail buffering
benherber
force-pushed
the
GH-5210-bulk-flush-to-child-sail
branch
from
43064ff to
e7a04f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5210
Briefly describe the changes proposed in this PR:
This PR adds an overridable internal method
bulkAddStatementsInternalwhich implementing SAILs can use to leverage the existing multithreading-safe, buffering implemented inAbstractSailConnection. This change should be fully backwards compatible as it defaults to the exiting implementation.PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)