Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature request template #132

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add feature request template #132

merged 1 commit into from
Dec 19, 2024

Conversation

antonkri
Copy link
Contributor

Issue-ref: closes #37

Copy link

@antonkri antonkri force-pushed the ankr_feature_request branch from 7589333 to 7728b63 Compare December 19, 2024 07:46
Copy link

@antonkri antonkri changed the title WIP: Add feature request template Add feature request template Dec 19, 2024
@antonkri antonkri requested a review from masc2023 December 19, 2024 12:41
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@antonkri antonkri force-pushed the ankr_feature_request branch from 7728b63 to aaa1eab Compare December 19, 2024 14:06
Copy link

masc2023
masc2023 previously approved these changes Dec 19, 2024
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, two small issues, for the naming of the directives

Copy link

Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonkri antonkri merged commit 0030bc6 into main Dec 19, 2024
8 checks passed
@antonkri antonkri deleted the ankr_feature_request branch December 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial Version of Contribution Request
2 participants