-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webpack config #136
Fix webpack config #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duncdrum thank you for the contribution, please be sure to properly sign the eclipse contributor agreement (eca) with the same email as your authorship in order to for the project to accept your changes (it is the reason for the currently failing CI check).
In addition, please amend your commit title as there are typos:
docs(readme): make node 12 requiremen explicit
waiting for for |
db53dc9
to
8ba8b1b
Compare
Thanks @duncdrum - the content looks good to me. Would you be able to squash these 3 commits, e.g. replacing them with one commit: "misc README updates" or such? If you're not sure how to do that I can help - just ask. |
typos, misc fixes add warning about projects-storage.eclipse.org connection
0593025
to
ca57719
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @duncdrum for your first merged contribution to our project!
What it does
Checks the user configurable
webpack.congig.js
into the git.close #134
How to test
Review checklist
Reminder for reviewers