Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack config #136

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

duncdrum
Copy link
Contributor

@duncdrum duncdrum commented Aug 9, 2021

What it does

Checks the user configurable webpack.congig.js into the git.

close #134

How to test

  • see e2e-est
  • make sure that file is not ignored

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duncdrum thank you for the contribution, please be sure to properly sign the eclipse contributor agreement (eca) with the same email as your authorship in order to for the project to accept your changes (it is the reason for the currently failing CI check).

In addition, please amend your commit title as there are typos:

docs(readme): make node 12 requiremen explicit

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
applications/electron/webpack.config.js Show resolved Hide resolved
@duncdrum
Copy link
Contributor Author

duncdrum commented Aug 9, 2021

waiting for for [email protected] to get back to me, something not working with my account sign-up despite there being a green note claiming success

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@marcdumais-work
Copy link
Contributor

Thanks @duncdrum - the content looks good to me. Would you be able to squash these 3 commits, e.g. replacing them with one commit: "misc README updates" or such?
image

If you're not sure how to do that I can help - just ask.

typos, misc fixes
add warning about projects-storage.eclipse.org connection
@duncdrum
Copy link
Contributor Author

done

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @duncdrum for your first merged contribution to our project!

@marcdumais-work marcdumais-work merged commit fdc4a93 into eclipse-theia:master Aug 12, 2021
@duncdrum duncdrum deleted the fix-wp-config branch August 12, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated gitignore is too strict
3 participants