Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add chart missing files #32

Merged

Conversation

tomaszbarwicki
Copy link
Contributor

PR to add missing helm chart LICENSE & README.md files.

Updates eclipse-tractusx/sig-infra#287

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failed checks on the bottom.

  • You need to bump the chart version in the Chart.yaml because you added files to it and helm-chart-releaser can't release with an already existing chart version.
  • The quality checks are failed for 2 reasons: base image is not supported and resource limits are not set for pod

@tomaszbarwicki
Copy link
Contributor Author

There are some failed checks on the bottom.

  • You need to bump the chart version in the Chart.yaml because you added files to it and helm-chart-releaser can't release with an already existing chart version.
  • The quality checks are failed for 2 reasons: base image is not supported and resource limits are not set for pod

Issues addressed, except base image which is not on approved images list. Perhaps we can fix that later on.

@almadigabor
Copy link
Contributor

almadigabor commented Oct 12, 2023

Also updated the DEPENDENCIES file, opened IP issues and the following output was generated:

[main] INFO A review is required for go/golang/golang.org%2Fx/tools/v0.8.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11052 .
[main] INFO A review is required for go/golang/github.com%2Fgoogle/gnostic-models/v0.6.9-0.20230804172637-c7be7c783f49.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/10742 .
[main] INFO A review is required for go/golang/golang.org%2Fx/text/v0.13.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/10752 .
[main] INFO A review is required for go/golang/golang.org%2Fx/sys/v0.13.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11053 .
[main] INFO A review is required for go/golang/github.com%2Fgo-task/slim-sprig/v0.0.0-20230315185526-52ccab3ef572.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/10759 .
[main] INFO A review is required for go/golang/golang.org%2Fx/net/v0.17.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11054 .
[main] INFO A review is required for go/golang/golang.org%2Fx/oauth2/v0.13.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11055 .
[main] INFO A review is required for go/golang/golang.org%2Fx/term/v0.13.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11056 .

Copy link

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 8f1fa3b into eclipse-tractusx:main Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants