Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Orchestrator): ignore resolutions for already resolved steps #1091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Oct 25, 2024

Description

This pull request changes the Orchestrator's behaviour when receiving resolutions for already resolved steps for a task.

  • return 200 status code when posting resolution already resolved steps ignoring the content
  • adapted tests

Solves #1092

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow force-pushed the feat/ignore-duplicate-resolutions branch from b5af45c to bc30e8a Compare October 25, 2024 09:50
- return 200 status code when posting resolution already resolved steps ignoring the content
- adapted tests
@nicoprow nicoprow force-pushed the feat/ignore-duplicate-resolutions branch from bc30e8a to a4ac711 Compare October 25, 2024 10:16
@nicoprow nicoprow marked this pull request as ready for review October 28, 2024 09:17
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Nov 14, 2024
@nicoprow nicoprow added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants