Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpdm-common): SwaggerUiConfigProperties optional in Landing Page #1096

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

SujitMBRDI
Copy link
Contributor

Description

In this pull request, made SwaggerUiConfigProperties optional in LandingPageConfig.

  • Updated LandingPageConfig to accept a nullable SwaggerUiConfigProperties dependency
  • Added null check in addViewControllers to handle cases where SwaggerUiConfigProperties is not available
  • Ensures application can start without requiring SwaggerUiConfigProperties, improving flexibility in test and non-Swagger environments

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI marked this pull request as ready for review October 28, 2024 12:42
@SujitMBRDI SujitMBRDI merged commit 3e0960b into main Oct 29, 2024
15 of 16 checks passed
@nicoprow nicoprow deleted the feat/landing-page-conf branch October 31, 2024 02:10
@nicoprow nicoprow added this to the BPDM v6.2.0 / R24.12 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants