Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Checksum change to include also the Prefix BPN(L-S-A) #965

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

AmirMattarx
Copy link
Contributor

@AmirMattarx AmirMattarx commented Jun 13, 2024

Description

Including the BPN prefix into the checksum calculation .

It solves the issue :

eclipse-tractusx/sig-release#699

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmirMattarx The change looks good to me and the tests run through with the changed test data.

Since main had a big change recently, please rebase the changes on top of the current main and force-push them to this branch.

Also feel free to squash the two commits into one, as I don't think this feature needs to split into two commits.

@maximilianong maximilianong self-requested a review June 20, 2024 10:27
@nicoprow nicoprow merged commit 7e3bd98 into eclipse-tractusx:main Jun 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants