Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add taxJurisdictionCode field to physical address #972

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jun 20, 2024

Description

This pull request adds the new field 'taxJurisdictionCode' to the business partner's physical address

  • changed API models
  • added database column
  • adapted the mappings
  • enhanced the test data
  • updated the api documentation

implements to #955

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow marked this pull request as ready for review June 20, 2024 10:43
@nicoprow nicoprow requested a review from SujitMBRDI June 20, 2024 10:43
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me. Just need to make decision related to api docs version.

@@ -3,14 +3,22 @@
"info": {
"title": "Business Partner Data Management Gate",
"description": "A gate for a member to share business partner data with CatenaX",
"version": "6.0.0"
"version": "6.0.2-SNAPSHOT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is updated now, need to update docs of api for each service or we shall prefer to adapt the same during feature freeze?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the API docs with the newest SNAPSHOT version and then we can have a final look again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can do that.

…dress

- changed API models
- added database column
- adapted the mappings
- enhanced the test data
- updated the api documentation

implements to #955
@nicoprow nicoprow merged commit f153edf into main Jun 26, 2024
16 checks passed
@nicoprow nicoprow deleted the feat/tax-jurisdiction branch July 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants