feat(LegalSiteAPI): New endpoint to create legal site reference #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Jul 18, 2024
There was a problem hiding this comment.
This is a really good first pull request. The actual logic looks good to me and also tests are there.
I'm not happy with the naming of the REST resource though and this pull request would need to be rebased on the current main (during my review this could be done without conflicts).
bpdm-pool-api/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/api/PoolSiteApi.kt
Outdated
Show resolved
Hide resolved
bpdm-pool-api/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/api/PoolSiteApi.kt
Outdated
Show resolved
Hide resolved
bpdm-pool-api/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/api/PoolSiteApi.kt
Outdated
Show resolved
Hide resolved
nicoprow
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Content works and looks great!
Last bit is about conformity:
- Please rebase your branch on the newest version of main
- Squash your commits to one so that only one commit is on top of the main branch
- This is not a patch version upgrade but since it brings anew feature to the API the maven version should be updated to 6.2.0-SNAPSHOT
- Please add an entry into the CHANGELOG.md file under
## [6.2.0] - tbd
dilipdhankecha2530
force-pushed
the
feat-add-legal-site-endpoint
branch
3 times, most recently
from
e38f590
to
3d7cbad
Compare
…galAndSiteMainAddress addressType 1. Create an endpoint to create site entity 2. Create SiteCreateRequestWithLegalAddressAsMain in bpdm-pool-api module 3. Add test cases which cover the new code 4. Add 6.2.0 changelog version in CHANGELOG.md file 5. Rebasing with upstream 6. Update the revision version to 6.2.0-SNAPSHOT in pom.xml 7. Update the charts version
dilipdhankecha2530
force-pushed
the
feat-add-legal-site-endpoint
branch
from
1686927
to
dc4ef42
Compare
nicoprow
approved these changes
Aug 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR introduce?
Does it fix a bug?
Does it add a new feature?
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: