-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(partnerNetwork): Get data from partner network pool by portal backend (#61) #1082
base: main
Are you sure you want to change the base?
feat(partnerNetwork): Get data from partner network pool by portal backend (#61) #1082
Conversation
before merging/approving please look into the comment of the issue #1079 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not doing anything else than mapping BpdmPartnerNetworkData to PartnerNetworkResponse. No access to portal db is done, this implements more or less a reverse proxy. From my point of view @oyo 's comment #1079 (comment) is valid and the implementation of a reverse-proxy should be considered.
Description
Developed an API in portal-backend to get data from partner-network-pool instead of calling business-partner-pool service directly from the portal-frontend.
Why
This approach will make it consistent and secure, as we are already been calling business-partner-pool service from portal-backed to get legal-entity data by BPN.
Issue
Ref: #1079
Corresponding Configuration PR
eclipse-tractusx/portal#461
Checklist