Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented days of supply edc integration #694

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: implemented days of supply edc integration #694

wants to merge 3 commits into from

Conversation

ReneSchroederLJ
Copy link
Contributor

@ReneSchroederLJ ReneSchroederLJ commented Nov 27, 2024 •
edited
Loading

Description

  • add SAMM models for Days of Supply
  • implemented logic for registering the corresponding Assets and Contract
  • implemented the request service for exchanging Days of Supply through the EDC

reolves #312

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
...src/main/java/org/eclipse/tractusx/puris/backend/demand/logic/services/OwnDemandService.java Fixed Show fixed Hide fixed
.../java/org/eclipse/tractusx/puris/backend/supply/logic/dto/daysofsupplysamm/DaysOfSupply.java
import lombok.ToString;

@Getter
@Setter

Check notice

Code scanning / CodeQL

Exposing internal representation Note

setAllocatedDaysOfSupply exposes the internal representation stored in field allocatedDaysOfSupply. The value may be modified
through the variable suppliesPerDay
Loading
.
setAllocatedDaysOfSupply exposes the internal representation stored in field allocatedDaysOfSupply. The value may be modified
through the variable suppliesPerDay
Loading
.
...a/org/eclipse/tractusx/puris/backend/supply/logic/service/DaysOfSupplyRequestApiService.java
case INBOUND -> mprService.findByPartnerAndPartnerCXNumber(partner, materialNumberCx);
};
if (mpr == null) {
log.error("Could not identify Material-Partner Relation with material number " + materialNumberCx + " and partner bpnl " + partner.getBpnl());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
Loading
.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value for materialNumberCx is verified as URN or UUID before use and should not pose a risk.

@ReneSchroederLJ ReneSchroederLJ marked this pull request as ready for review November 27, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST Awaiting requested review from tom-rm-meyer-ISST

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReneSchroederLJ