Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create KIT Issue Template #983

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ther3sa
Copy link
Contributor

@ther3sa ther3sa commented Oct 28, 2024

Description

Created KIT Issue Template with topics

  • Description
  • Impact
  • KIT Team
  • Architectural Relevance

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ther3sa ther3sa self-assigned this Oct 28, 2024
@ther3sa ther3sa marked this pull request as ready for review October 28, 2024 15:42
@stephanbcbauer stephanbcbauer requested a review from a team October 29, 2024 14:55
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important to mention and link to our TRGs. For example, we have the TRG 9.01 especially for KITs:
https://eclipse-tractusx.github.io/docs/release/trg-0/trg-9-01

The feature template should include a checkbox to validate if it confirms the relevant TRGs.

Maybe this could make more sense to include it in a pull request template for KITs.

Copy link

@eckardg eckardg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, thanks!

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@tom-rm-meyer-ISST
Copy link

It is important to mention and link to our TRGs. For example, we have the TRG 9.01 especially for KITs: https://eclipse-tractusx.github.io/docs/release/trg-0/trg-9-01

The feature template should include a checkbox to validate if it confirms the relevant TRGs.

Maybe this could make more sense to include it in a pull request template for KITs.

The template is for KIT Feature proposals during planning not for the QGate Tickets. Thus, I would not mention the TRGs already at that state.

Copy link

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvements and one big question: Do we really want the architectural relevance checks in the feature template? Similar to my comment on the TRGs, the architectural relevance may be checked only during QGate.

As no KITs are creaed if no standard exists, the architectural relevance should have already been gatekeept on standardization level.

- [ ] [CX-0001 EDC Discovery API](https://catenax-ev.github.io/docs/next/standards/CX-0001-EDCDiscoveryAPI)
- [ ] [CX-0002 Digital Twins in Catena-X](https://catenax-ev.github.io/docs/next/standards/CX-0002-DigitalTwinsInCatenaX)
- [ ] [CX-0018 Dataspace Connectivity](https://catenax-ev.github.io/docs/next/standards/CX-0018-DataspaceConnectivity)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Please remove empty line

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As no KITs are creaed if no standard exists" -> I would not say that this is always the case. And often it is only visible in the KIT how the standard is going to be applied.
To my mind, it helps to bring the guidelines as soon as possible to awareness.

- Contributor 2

### Committer
<!-- names are already needed for open planning -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I'm always unaware of: who is the assignee of the ticket? Is it the responsible or the responsible committers + contributors? It might might sense to state that in the comment in here that the committers and / or contributers should also be assigned (increases sanity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants