Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding grpc examples #107

Merged
merged 11 commits into from
Oct 30, 2024

Conversation

erikbosch
Copy link
Contributor

Example matching documentation in eclipse-velocitas/velocitas-docs#129

CPPLINT.cfg Show resolved Hide resolved
@erikbosch erikbosch marked this pull request as ready for review October 29, 2024 11:47
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/grpc_client/src/Launcher.cpp Outdated Show resolved Hide resolved
examples/grpc_client/src/CMakeLists.txt Outdated Show resolved Hide resolved
@erikbosch erikbosch requested a review from MP91 October 29, 2024 14:11
MP91
MP91 previously approved these changes Oct 30, 2024
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Currently stuck in

eclipsefdn/eca Expected — Waiting for status to be reported
@erikbosch erikbosch merged commit 216a7f2 into eclipse-velocitas:main Oct 30, 2024
5 checks passed
@erikbosch erikbosch deleted the erik_example branch October 30, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants