Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Guava's Objects by java.util.Objects #2992

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

HannesWell
Copy link
Contributor

All changes are competently internal.

This change intentionally does not cover XbaseCompiler and ObjectExtensions (which were at least my actual goal). It will be covered in a separate PR together will all the Xtend generated Java sources and adjustments of the test expectations.

Part of #2975

Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szarnekow I'm fine with this, what do you think?

Copy link
Contributor

@szarnekow szarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to be merged.

@szarnekow szarnekow added this to the Release_2.35 milestone Apr 15, 2024
@LorenzoBettini LorenzoBettini merged commit 9b26bcf into eclipse-xtext:main Apr 15, 2024
6 checks passed
@LorenzoBettini
Copy link
Contributor

Thanks @HannesWell

@HannesWell HannesWell deleted the replace-guava-objects branch April 15, 2024 16:36
@HannesWell
Copy link
Contributor Author

Thank you for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants