-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization feature #158
Open
DariusIMP
wants to merge
85
commits into
eclipse-zenoh:main
Choose a base branch
from
ZettaScaleLabs:serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' functions in it.
…' functions in it.
…uilder' functions in it.
…uilder' functions in it.
…'builder' functions in it.
…' functions in it.
…allback subclasses + tidying up documentation.
PR missing one of the required labels: {'enhancement', 'internal', 'dependencies', 'new feature', 'documentation', 'breaking-change', 'bug'} |
DariusIMP
added
enhancement
New feature or request
release
Part of the next release
labels
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #157.
Description
This PR introduces the serialization and deserialization features that were recently introduced to all the Zenoh bindings.
It's inspired by the Kotlin serialization and deserialization, however, due to Java's limitations (specifically due to Java's type erasure), in this PR we introduce a depencency to the Guava library which provide reflection capabilities, allowing us to know during runtime the types into which the ZBytes must be serialized or deserialized.
The API looks like this:
Java's type erasure forces us to require users to explicitely specify a
new TypeToken<>() {}
instance when callingzSerialize
orzDeserialize
. This creates a TypeToken instance storing the information regarding the input type at runtime.The supported types for serialization/deserialization are:
List and Map, which are parameterized types, support types nesting with any of the mentioned types. For instance:
Map<String, Map<String, Map<String, String>>>
is a supported type.