Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java compatible kotlin bindings #16

Merged

Conversation

DariusIMP
Copy link
Member

Adapting Zenoh-Kotlin bindings to be compatible with Java.

The features contained in this PR are the same ones from the 0.10.0-rc release of zenoh kotlin (see https://github.com/eclipse-zenoh/zenoh-kotlin/releases/tag/0.10.0-rc).

Differences:

  • Replacing everything that's pure kotlin with somewhat equivalent Java compatible code:

    • Using BlockingQueue with Optional instead of Kotlin's Channels used with Coroutines
    • Replacing all Results with Exceptions throwing
    • Added "ZenohException" wrapping the existing Exceptions thrown through JNI, for better exception handling.
    • Replacing kotlin's "extension functions" String.intoKeyExpr() and String.intoSelector() by static methods on the KeyExpr and Selector classes respectively, offering a similar functionality.
  • Added Java examples with pure Java code using the library.

  • Updated the KDoc comments with Java code examples.

- Config utilities
- JVM packaging capabilities
@DariusIMP DariusIMP marked this pull request as ready for review December 15, 2023 16:18
@Mallets Mallets merged commit dfb1e34 into eclipse-zenoh:master Dec 15, 2023
3 checks passed
@Mallets Mallets deleted the java_compatible_kotlin_bindings branch December 15, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants