-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding onClose behaviour for Get, Queryable and Subscribers. #9
Merged
OlivierHecart
merged 19 commits into
eclipse-zenoh:main
from
ZettaScaleLabs:queryables_end
Oct 16, 2023
Merged
Adding onClose behaviour for Get, Queryable and Subscribers. #9
OlivierHecart
merged 19 commits into
eclipse-zenoh:main
from
ZettaScaleLabs:queryables_end
Oct 16, 2023
+297
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiplatform plugin
Also: - fix Examples build - tidy up build.gradle.kts files - triggering compile zenoh-jni if needed when running gradle tasks.
The possibility of adding an onFinish callback for Get requests, Subscribers and Queryables is added to their respective builders. Also the Handler interface is expanded with an "onFinish" callback (in the case of the default handler, which is ChannelHandler, the implementation consists of closing the channel upon finishing).
@Mallets @OlivierHecart wanna chime in on the name of the event? I had |
DariusIMP
changed the title
Adding OnFinish behaviour for Get, Queryable and Subscribers.
Adding onClose behaviour for Get, Queryable and Subscribers.
Oct 16, 2023
DariusIMP
added a commit
to ZettaScaleLabs/zenoh-kotlin
that referenced
this pull request
Oct 17, 2023
…-zenoh#9) * Restructuring packages aiming for Android compatibility, using Kotlin multiplatform plugin * Edit cargo task in build.gradle.kts * Reenabling examples. * Making jvmTest commonTest * [WIP] Target building Zenoh JNI * Editing workflows after multiplatforming project. * Editing README and build.gradle.kts * Publish to JVM. * Publish to JVM. Also: - fix Examples build - tidy up build.gradle.kts files - triggering compile zenoh-jni if needed when running gradle tasks. * Fix CI + edit README * Fix CI + edit README * OnFinish callback feature. The possibility of adding an onFinish callback for Get requests, Subscribers and Queryables is added to their respective builders. Also the Handler interface is expanded with an "onFinish" callback (in the case of the default handler, which is ChannelHandler, the implementation consists of closing the channel upon finishing). * Fix doc comment. * Fix formatting of Zenoh-JNI * Renaming 'onFinish' with 'onClose'. * Fix cargo fmt * Fix CI workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add the possibility of adding an onClose callback for Get requests, Subscribers and Queryables.
This is added to their respective builders, for instance:
Also the Handler interface is expanded with an "onClose" callback.
In the case of the default handler, which is ChannelHandler, the implementation consists of closing the channel upon finishing:
If implementations of both mechanisms (on finish through the handler and on finish through the builders) are provided, they are stacked and both will be executed.
When does it happen that the onClose callbacks are invoked:
Kudos to @p-avital for his contribution to this PR by providing the low level utilities (like the
CallOnDrop
functionality).