fallible serialization #1544
Draft
fallible serialization #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'internal', 'documentation', 'new feature', 'bug', 'enhancement', 'breaking-change', 'dependencies'} |
|
PR missing one of the required labels: {'bug', 'dependencies', 'new feature', 'documentation', 'breaking-change', 'enhancement', 'internal'} |
milyin
added
enhancement
wyfo
reviewed
Oct 17, 2024
zenoh-ext/src/serialization.rs
Outdated
| @@ -33,18 +35,58 @@ impl fmt::Display for ZDeserializeError { | |||
| } | |||
| impl std::error::Error for ZDeserializeError {} | |||
|
|
|||
| fn default_serialize_n<T: Serialize>(slice: &[T], serializer: &mut ZSerializer) { | |||
| #[derive(Debug)] | |||
| pub struct ZSerializeError(String); | |||
There was a problem hiding this comment.
Why not using a ZST as it is the case for deserialization?
There was a problem hiding this comment.
Why not a Box<dyn Error + Send + Sync>?
There was a problem hiding this comment.
What is a ZST ? About Box - yes, agree, fixing
| /// See [Zenoh serialization format RFC][1]. | ||
| /// | ||
| /// [1]: https://github.com/eclipse-zenoh/roadmap/blob/main/rfcs/ALL/Serialization.md#sequences | ||
| pub fn try_serialize_iter<T: TrySerialize, I: IntoIterator<Item = T>>( |
|
@milyin At the end we decided to not include this PR in 1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z_try_serializefunction addedTrySerializeadded. The traitSerializeremains for infallible serializationTrySerialize<Error = Infallible>Serializetrait is implemeted automatically for all types which implementsTrySerialize<Error = Infallible>Serializeexplicitly for types which already implementsTrySerialize<Error = ZSerializeError>or any other error. This is necessary for e.g.HashMapCStringadded: in demonstration purpose and may be for future use in zenoh-c