fix: fix z_sub_thr termination and improve perf #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Thread::unpark` `std::process::exit` allows session to be closed, and callback final print to be executed. Callback lock accounted for 2.5% of z_sub_thr perf. Using atomic and fine-grained lock remove the performance impact (even if it doesn't really change the global outcome).
|
Any change on the example should be aligned with all Zenoh bindings. |
fuzzypixelz
approved these changes
Nov 26, 2024
|
Just to reiterate on the point. Any change in examples needs to be coordinated across all bindings. I'm marking this PR as invalid for the time being till further actions are taken. Either closing the PR or providing updates to all other bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Thread::unparkstd::process::exitallows session to be closed, and callback final print to be executed.Callback lock accounted for 2.5% of z_sub_thr perf. Using atomic and fine-grained lock remove the performance impact (even if it doesn't really change the global outcome).