fix: fix callback API #1647
Merged
fix: fix callback API #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'internal', 'bug', 'dependencies', 'new feature', 'enhancement', 'documentation'} |
OlivierHecart
merged commit b807ee8
into
eclipse-zenoh:dev/advanced_pubsub
13 of 14 checks passed
OlivierHecart
added a commit
that referenced
this pull request
Dec 11, 2024
* Expose and use ke macro * Fix SourceInfo publication * Add AdvancedPublisher AdvancedSubscriber and AdvancedSubscriber * Fix doctests * Fix doc warnings * Remove debug trace * Add history test * Fix periodic queries * Remove debug trace * Lower test debug level * Add retransmission tests * Liveliness sub callback shoud increase pending queries counter * Liveliness sub callback shoud spawn periodic queries when enbaled * Add late_joiner test * Only treat pending samples when there are no more pending queries * Apply proper sequencing for history * Improve AdvancedSubscriber * Code reorg * Code reorg * Fix deduplication * Subscribe to liveliness tokens with history * Update builders * Add examples * Fix rustdoc * Move stuff in State * Code reorg * Add smaple_miss_callback * Add sample miss test * Update z_advanced_sub example * Explicit use in examples * Update API * Fix rustdoc * Allow sample miss detection when recovery disabled * Add miss_sample_callback to DataSubscriberBuilderExt * Add sample_miss_detection to PublisherBuilderExt * Add test_advanced_sample_miss test * Deliver sample even when no miss callback * Replace sample_miss_callback with sample_miss_listener * Fix clippy warnings * Fix tests * Add HistoryConf max_samples option * Add HistoryConf max_age option * Use BTreeMap * Add meta_keyexpr option * Add late_joiner_detection and meta_keyexpr options on Subcriber side * Renaming * Fix compilation issues * Remove AdvancedCache from public API * Update Session admin to match AdvancedSub * Gather constants * Fix doc build * Renaming * Mark PublicationCache and QueryingSubscriber as deprecated and remove related examples * Remove z_pub_cache and z_query_sub entries from zenoh-ext examples README * Add z_advanced_pub and z_advanced_sub to zenoh-ext examples Cargo.toml * Add CacheConfig replies_qos option * Call cache directly from publisher * Update doc * Add missing unstable tags * Add missing unstable tags * Add missing unstable tags * Add unstable tag everywhere * Add missing AdvancedSubscriber methods * Fix WeakSession::Session internal function * Expose missing SampleMissListener and related structs * Add AdvancedPublisherBuilderExt::advanced function * Add missing AdvancedPublisherBuilder functions * Fix doctests * Expose Miss struct * impl QoSBuilderTrait for AdvancedPublisherBuilder * Propagate PublisherBuilder values to AdvancedPublisherBuilder * Rename AdvancedSubscriber::close() * Add unstable tags * Add AdvancedSubscriber::detect_publishers function * Remove debug println * Renaming * Add unstable tags * Use std Range * Spawn Timer in a tokio runtime * Fix panic when last_delivered is None * Release lock before calling get * Update key mapping * Improve doc * fix: fix callback API (#1647) * Update doc * Fix ke_liveliness * Fix doc * Fix doc --------- Co-authored-by: Joseph Perez <[email protected]>
milyin
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Expose and use ke macro * Fix SourceInfo publication * Add AdvancedPublisher AdvancedSubscriber and AdvancedSubscriber * Fix doctests * Fix doc warnings * Remove debug trace * Add history test * Fix periodic queries * Remove debug trace * Lower test debug level * Add retransmission tests * Liveliness sub callback shoud increase pending queries counter * Liveliness sub callback shoud spawn periodic queries when enbaled * Add late_joiner test * Only treat pending samples when there are no more pending queries * Apply proper sequencing for history * Improve AdvancedSubscriber * Code reorg * Code reorg * Fix deduplication * Subscribe to liveliness tokens with history * Update builders * Add examples * Fix rustdoc * Move stuff in State * Code reorg * Add smaple_miss_callback * Add sample miss test * Update z_advanced_sub example * Explicit use in examples * Update API * Fix rustdoc * Allow sample miss detection when recovery disabled * Add miss_sample_callback to DataSubscriberBuilderExt * Add sample_miss_detection to PublisherBuilderExt * Add test_advanced_sample_miss test * Deliver sample even when no miss callback * Replace sample_miss_callback with sample_miss_listener * Fix clippy warnings * Fix tests * Add HistoryConf max_samples option * Add HistoryConf max_age option * Use BTreeMap * Add meta_keyexpr option * Add late_joiner_detection and meta_keyexpr options on Subcriber side * Renaming * Fix compilation issues * Remove AdvancedCache from public API * Update Session admin to match AdvancedSub * Gather constants * Fix doc build * Renaming * Mark PublicationCache and QueryingSubscriber as deprecated and remove related examples * Remove z_pub_cache and z_query_sub entries from zenoh-ext examples README * Add z_advanced_pub and z_advanced_sub to zenoh-ext examples Cargo.toml * Add CacheConfig replies_qos option * Call cache directly from publisher * Update doc * Add missing unstable tags * Add missing unstable tags * Add missing unstable tags * Add unstable tag everywhere * Add missing AdvancedSubscriber methods * Fix WeakSession::Session internal function * Expose missing SampleMissListener and related structs * Add AdvancedPublisherBuilderExt::advanced function * Add missing AdvancedPublisherBuilder functions * Fix doctests * Expose Miss struct * impl QoSBuilderTrait for AdvancedPublisherBuilder * Propagate PublisherBuilder values to AdvancedPublisherBuilder * Rename AdvancedSubscriber::close() * Add unstable tags * Add AdvancedSubscriber::detect_publishers function * Remove debug println * Renaming * Add unstable tags * Use std Range * Spawn Timer in a tokio runtime * Fix panic when last_delivered is None * Release lock before calling get * Update key mapping * Improve doc * fix: fix callback API (#1647) * Update doc * feat: add background to advanced subscriber * Fix ke_liveliness * fix: add missing mut * Fix doc * Fix doc * Fix zenoh-ext Cargo.toml --------- Co-authored-by: OlivierHecart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.