Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency jsonwebtoken to 9.0.0 [security] - abandoned #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 23, 2022

Mend Renovate

This PR contains the following updates:

Package Change
jsonwebtoken 8.5.1 -> 9.0.0

GitHub Vulnerability Alerts

CVE-2022-23540

Overview

In versions <=8.5.1 of jsonwebtoken library, lack of algorithm definition in the jwt.verify() function can lead to signature validation bypass due to defaulting to the none algorithm for signature verification.

Am I affected?

You will be affected if you do not specify algorithms in the jwt.verify() function

How do I fix it?

Update to version 9.0.0 which removes the default support for the none algorithm in the jwt.verify() method.

Will the fix impact my users?

There will be no impact, if you update to version 9.0.0 and you don’t need to allow for the none algorithm. If you need 'none' algorithm, you have to explicitly specify that in jwt.verify() options.

CVE-2022-23539

Overview

Versions <=8.5.1 of jsonwebtoken library could be misconfigured so that legacy, insecure key types are used for signature verification. For example, DSA keys could be used with the RS256 algorithm.

Am I affected?

You are affected if you are using an algorithm and a key type other than the combinations mentioned below

Key type algorithm
ec ES256, ES384, ES512
rsa RS256, RS384, RS512, PS256, PS384, PS512
rsa-pss PS256, PS384, PS512

And for Elliptic Curve algorithms:

alg Curve
ES256 prime256v1
ES384 secp384r1
ES512 secp521r1

How do I fix it?

Update to version 9.0.0. This version validates for asymmetric key type and algorithm combinations. Please refer to the above mentioned algorithm / key type combinations for the valid secure configuration. After updating to version 9.0.0, If you still intend to continue with signing or verifying tokens using invalid key type/algorithm value combinations, you’ll need to set the allowInvalidAsymmetricKeyTypes option to true in the sign() and/or verify() functions.

Will the fix impact my users?

There will be no impact, if you update to version 9.0.0 and you already use a valid secure combination of key type and algorithm. Otherwise, use the allowInvalidAsymmetricKeyTypes option to true in the sign() and verify() functions to continue usage of invalid key type/algorithm combination in 9.0.0 for legacy compatibility.

CVE-2022-23541

Overview

Versions <=8.5.1 of jsonwebtoken library can be misconfigured so that passing a poorly implemented key retrieval function (referring to the secretOrPublicKey argument from the readme link) will result in incorrect verification of tokens. There is a possibility of using a different algorithm and key combination in verification than the one that was used to sign the tokens. Specifically, tokens signed with an asymmetric public key could be verified with a symmetric HS256 algorithm. This can lead to successful validation of forged tokens.

Am I affected?

You will be affected if your application is supporting usage of both symmetric key and asymmetric key in jwt.verify() implementation with the same key retrieval function.

How do I fix it?

Update to version 9.0.0

Will the fix impact my users?

There is no impact for end users


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 23, 2022
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 4%, saving 24.23 KB.

Filename Before After Improvement Visual comparison
template/public/img/uploads/1920_x_600px.webp 41.80 KB 40.57 KB -2.9% View diff
template/public/img/uploads/800_x_940px.webp 40.94 KB 39.88 KB -2.6% View diff
template/public/img/uploads/banner-1.webp 65.84 KB 62.08 KB -5.7% View diff
template/public/img/uploads/banner-2.webp 73.28 KB 69.61 KB -5.0% View diff
template/public/img/uploads/banner-3.webp 169.16 KB 163.71 KB -3.2% View diff
template/public/img/uploads/banner-4.webp 28.26 KB 27.21 KB -3.7% View diff
template/public/img/uploads/banner-5.webp 11.47 KB 11.03 KB -3.8% View diff
template/public/img/uploads/banner-6.webp 12.87 KB 12.40 KB -3.7% View diff
template/public/img/uploads/banner-amor.webp 12.87 KB 12.40 KB -3.7% View diff
template/public/img/uploads/banner-blusa.webp 12.21 KB 11.71 KB -4.0% View diff
template/public/img/uploads/banner-vestido.webp 28.26 KB 27.21 KB -3.7% View diff
template/public/img/uploads/modelo-aprovado-1920-x-600-px_-1-1-.webp 53.97 KB 50.60 KB -6.2% View diff
template/public/img/uploads/modelo-aprovado-800-x-940_-1-1-.webp 44.27 KB 42.69 KB -3.6% View diff
template/public/img/uploads/slider.jpg 5.41 KB 5.27 KB -2.6% View diff

71 images did not require optimisation.

@renovate
Copy link
Contributor Author

renovate bot commented Dec 23, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency jsonwebtoken to 9.0.0 [security] chore(deps): update dependency jsonwebtoken to 9.0.0 [security] - abandoned Mar 23, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Mar 23, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants