[ECO-2195] Add market discovery rain #304
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alnoki
reviewed
Oct 22, 2024
CRBl69
added
urgency-low
xbtmatt
reviewed
Oct 31, 2024
| @@ -364,6 +365,7 @@ export type DatabaseJsonType = { | |||
| close_price_q64: Uint64String; | |||
| } | |||
| >; | |||
| [DatabaseRpc.RandomNames]: { emojis: string }; | |||
There was a problem hiding this comment.
Is there a more specific format to expect? It looks like it might be in the form of hex with an x prepended? It'd be nice to have it here just so it's clear what to expect when calling this function
You can do something like x${string}
|
@xbtmatt nothing is showing up because the backend is not up to date and does not have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it rain.
The launch page now rains with random unregistered market names.
Clicking on one will pre-fill the input.
Testing
See vecrel.