Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2360] Add claim link module to rewards package #320

Merged
merged 25 commits into from
Nov 15, 2024
Merged

[ECO-2360] Add claim link module to rewards package #320

merged 25 commits into from
Nov 15, 2024

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented Nov 1, 2024 •
edited
Loading

Description

  1. Run aptos move fmt on rewards package
  2. Add a claim link module that can be added in-place to the rewards package through module upgrade with init_module on the new module
  3. Bump package version

Testing

emojicoin_dot_fun_claim_link module tested to 100% coverage. From in repo root:

cd src/move/rewards
aptos move test --dev --move-2 --coverage

Note that per aptos-labs/aptos-core#15284 the test_general_flow test fails non-deterministically. If it fails, running it again will probably result in a pass, eventually.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you check all checkboxes from the linked Linear task?

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun 🛑 Canceled (Inspect) Nov 15, 2024 1:45am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 1:45am

@alnoki alnoki requested a review from xbtmatt November 1, 2024 01:33
@alnoki alnoki removed the request for review from xbtmatt November 1, 2024 18:53
@alnoki alnoki added urgency-high Please check first size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. labels Nov 1, 2024
@alnoki alnoki requested a review from CRBl69 November 15, 2024 01:53
@alnoki alnoki enabled auto-merge (squash) November 15, 2024 02:35
@alnoki alnoki merged commit b5f7b27 into main Nov 15, 2024
6 of 7 checks passed
@alnoki alnoki deleted the ECO-2360 branch November 15, 2024 02:36
xbtmatt pushed a commit that referenced this pull request Nov 15, 2024
@alnoki @xbtmatt
[ECO-2360] Add claim link module to rewards package (#320)
987b9c6
xbtmatt pushed a commit that referenced this pull request Nov 15, 2024
@alnoki @xbtmatt
[ECO-2360] Add claim link module to rewards package (#320)
ec09925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbtmatt xbtmatt xbtmatt approved these changes

@CRBl69 CRBl69 Awaiting requested review from CRBl69

Assignees
No one assigned
Labels
size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. urgency-medium Check after high urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnoki @xbtmatt