-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2420] Refactor claim link module for ease of DevOps #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alnoki
changed the title
[ECO-2420] Add bulk gas escrow fund API, tests
[ECO-2420] Refactor claim link module for ease of DevOps
Nov 17, 2024
xbtmatt
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add_public_keys_and_fund_gas_escrows
API with 100% coverage testing.for_each
tofor_each_ref
since the latter does not have to reverse the vector in place before iteration.claimed
andeligible
tables for ease of fetching eligible public keys.claimed
andeligible
table paradigm.Testing
emojicoin_dot_fun_claim_link
module tested to 100% coverage. From in repo root:cd src/move/rewards
aptos move test --dev --move-2 --coverage
Note that per aptos-labs/aptos-core#15284 the
test_general_flow
test fails non-deterministically. If it fails, running it again will probably result in a pass, eventually.Checklist