Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2420] Refactor claim link module for ease of DevOps #360

Merged
merged 17 commits into from
Nov 17, 2024
Merged

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented Nov 17, 2024

Description

  1. Implement add_public_keys_and_fund_gas_escrows API with 100% coverage testing.
  2. Update vector-wise for_each to for_each_ref since the latter does not have to reverse the vector in place before iteration.
  3. Split public keys into claimed and eligible tables for ease of fetching eligible public keys.
  4. Update assorted APIs as needed for claimed and eligible table paradigm.

Testing

emojicoin_dot_fun_claim_link module tested to 100% coverage. From in repo root:

cd src/move/rewards
aptos move test --dev --move-2 --coverage

Note that per aptos-labs/aptos-core#15284 the test_general_flow test fails non-deterministically. If it fails, running it again will probably result in a pass, eventually.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you check all checkboxes from the linked Linear task?

Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 4:35am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 4:35am

@xbtmatt xbtmatt enabled auto-merge (squash) November 17, 2024 04:47
@xbtmatt xbtmatt merged commit 86b6fc1 into main Nov 17, 2024
5 of 7 checks passed
@xbtmatt xbtmatt deleted the ECO-2420 branch November 17, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants