Test timers #20
Merged
Test timers #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test timers
Updated actions version and workflow README
* Pycharm reformatting and removal of redundant parentheses * Simplifying boolean expressions --------- Co-authored-by: Marius André Strand <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added test timing that is shown in the stdout.
Some troubleshooting was needed to understand why test information was not shown or saved. The problem was a hardcoded reference to
edamontology/caseologuein the YAML workflow files checkout section. This is not necessarily a problem when working in the original repo, but it makes working with forks difficult. Checkout is set to nothing now, so it follows the default behavior of checking out the current repo.I've also updated the workflow README and updated the GitHub actions to newer versions (v3) since v2 is being phased out. There should be no more warnings about nodes. Beyond this, I've done some reformatting suggested by Pycharm, simplified some boolean expressions, and removed unnecessary parentheses.