-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating detail panel #175
Conversation
This reworks allows to trigger js event in the tooltip within the tooltipBuilder
…to re-use it in tooltip, WIP #167
This looks good @bryan-brancotte exactly like that photoshopped one. |
button.btn already have display:inline-block, but div.tree-control-element doesn't, so we must set it
|
I didn't understand are you planning to remove term details panel in the right side, completely from the main page by displaying on hovering. There's no point of displaying it when it's already there on hovering. May be only for devices which doesn't have hovering action we can let the term details panel as it's. What do you think? I'm pointing this out cause when details table is displayed on hovering I didn't look over the right-side panel even once. Didn't need that. So, it might be removed now. And yeah those settings ideas are really great 👏 But @hmenager @matuskalas can tell better if they still want that table right-side. I'm not yet so much acquainted with the usability of edam-browser 😅 |
How about linking cookies for the storage of the state chosen for these three new buttons. I find that I've to change every time after refreshing. @bryan-brancotte I find this useful. 😅 This can be covered in other PR, cause current is itself a big jump in UI. |
|
…rology) remove `word-break: break-word;` after https://developer.mozilla.org/fr/docs/Web/CSS/word-break
No I don't, I even don't like to have the tooltip when not in fullscreen (that is why i disabled it years ago)
agrees, but some might find usefull to hover with only community usage, (maybe ?)
I don't really like the tooltip, so I hesitated to save it in storage, for now no, but indeed it would be sound to have it in storage.
Tooltip causes UI jump/glitch that is why I want to reduce its usage when not in fullscreen.
Clearly, but it would be by hand, not a "simple" bootstrap attribut.
It works sometime, but not all the time so not reliable |
Yes it's a good feature. It'll be helpful for sure. Hovering is quick.
Ok @bryan-brancotte now everything sounds good to me. |
Checklist
Issue
close/fix/resolve #167
details