Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new JOB queries #12

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Added new JOB queries #12

merged 3 commits into from
Oct 8, 2024

Conversation

amascolo
Copy link
Collaborator

@amascolo amascolo commented Oct 7, 2024

Checked by running sbt "testOnly * -- -n TestGJ" and similarly FJ, commenting out accordingly:

sdql/build.sbt

Lines 19 to 20 in a09c717

Tests.Argument(TestFrameworks.ScalaTest, "-l", "TestGJ"),
Tests.Argument(TestFrameworks.ScalaTest, "-l", "TestFJ"),

@amascolo
Copy link
Collaborator Author

amascolo commented Oct 7, 2024

@amascolo
Copy link
Collaborator Author

amascolo commented Oct 8, 2024

Note there might be a good reason to exclude 2c / 10b / 32a as noted in the free-join paper:

We exclude 5 queries from JOB that return empty results, since such empty queries
are known to introduce reproducibility issues.⁵

⁵ See GitHub issue: gregrahn/join-order-benchmark#11

@amascolo amascolo changed the title Added 5 new JOB queries Added new JOB queries Oct 8, 2024
@amascolo amascolo marked this pull request as ready for review October 8, 2024 16:25
@amascolo
Copy link
Collaborator Author

amascolo commented Oct 8, 2024

As discussed with @amiralikaboli, removing the null queries but keeping 13a / 13d as the result for 13d is expected due to how we do lexicographical ordering of ' vs ".

@amascolo amascolo merged commit e131874 into main Oct 8, 2024
@amascolo amascolo deleted the new-queries branch October 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant