Skip to content

Commit

Permalink
[ci]: make concurrency group more unique
Browse files Browse the repository at this point in the history
We notice that required CI checks cancel themselves even when attempting to merge a single PR at a time.
That is probably because there are CI jobs run on both 'push' and 'merge_group'.

Try to make the concurrency group more unique by adding the github event name to the group key.

Signed-off-by: Edwin Török <[email protected]>
  • Loading branch information
edwintorok committed Sep 18, 2024
1 parent 5d6a033 commit 807990b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
merge_group:

concurrency: # On new push, cancel old workflows from the same PR, branch or tag:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{github.event_name}}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/other.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
merge_group:

concurrency: # On new push, cancel old workflows from the same PR, branch or tag:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{github.event_name}}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/shellcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
merge_group:

concurrency: # On new push, cancel old workflows from the same PR, branch or tag:
group: sc-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: sc-${{ github.workflow }}-${{github.event_name}}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
Expand Down

0 comments on commit 807990b

Please sign in to comment.