(fix): In search block on edit, the sort on and sort order are not working #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobri1408
changed the title
ichim-david
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
@dobri1408 as I wrote in the pull request added in core the sorting works now until you select no value in which case the search preview doesn't update.
plone/volto#5262 (comment)
See if you can do something about it, it's not a major thing as the important thing is to get the sorting to work when you apply it but it would be nice to get the search preview to refresh when you basically remove any option from the sidebar widgets
ichim-david
added a commit
that referenced
this pull request
Mar 25, 2024
* Revert "(fix): In search block on edit, the sort on and sort order are not working (#205)" This reverts commit e6a6c2d. * feat(slate): add h4 in slate toolbar * Automated release 1.31.1 * change(slate): renamed addFormat to addSlateToolbarButton and pass an object it make it clearer on what does what in the options passed * style: Automated code fix * Automated release 1.31.1 * feat(slate): add new h3 slate element * Automated release 1.31.1 * change(slate): Use F as icon and renamed title of new heading Slate toolbar button to Figure title * style: Automated code fix * Automated release 1.31.1 * Update package.json * Automated release 1.32.0 --------- Co-authored-by: David Ichim <[email protected]> Co-authored-by: EEA Jenkins <@users.noreply.github.com> Co-authored-by: eea-jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volto pr: plone/volto#5262
Taskman: https://taskman.eionet.europa.eu/issues/258080