-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert OR detailed router drc file to klayout xml #607
Draft
kareefardi
wants to merge
6
commits into
dev
Choose a base branch
from
tr-to-klayoutxml
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
58bafed
Squashed commit of the following:
kareefardi af4a258
feat: convert OR detailed router drc file to klayout xml
kareefardi 636ac59
test: update magic drc test cases to use BoundingBox dataclass
kareefardi 5c76e54
Revert "test: update magic drc test cases to use BoundingBox dataclass"
kareefardi d14c1aa
dont break API for BoundingBox
kareefardi ab4f84f
Merge branch 'dev' into tr-to-klayoutxml
kareefardi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be pedantic but that's still an API break. If you were iterating over
.bounding_boxes
using:This code wouldn't work after this patch.
Can you reason why BoundingBoxWithDescription is needed? Can the information not be captured in
description
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why won't the code work? If
violations.bounding_boxes
is of typeList[BoundingBox]
code will still work.description
is common for all bounding boxes for a certain category. To add the additional information in the image below you need a text field with the bounding box. In the imageShort
is the description of certain category while the other is the additional text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made another update. I think it is more reasonable.Edit:
Not yet. local hook failed, fixing it..