Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:pass other apollo server options. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fakership
Copy link

@fakership fakership commented Dec 28, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@@ -1,3 +1,7 @@
2.3.1 / 2018-12-28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

history不需要改

// apollo server的透传参数
apolloServerOptions: {
rootValue,
formatError,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少单测,最好把formatError这个测试一下,测试下是否可以在应用外面接收到格式化后的error

const {
onPreGraphiQL,
onPreGraphQL,
apolloServerOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文档补一下,补在外面readme

@michaellyu
Copy link

请问这个apollo server options什么时候能更新,项目进行中,有点尴尬...

@catherinessssss
Copy link

请问这个options什么时候可以更新?

@whlsxl whlsxl mentioned this pull request Oct 25, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants