feat!: update to rollup v4 #1018
Conversation
sapphi-red
commented
Oct 8, 2023
sapphi-red
commented
- update rollup plugins for rollup v4 support
- update rollup to v4
- update minimum node version to 18 (rollup v4 supports Node 18+)
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "typescript": ">=4.1.0" | ||
| "typescript": ">=4.5.0" |
There was a problem hiding this comment.
rollup-plugin-dts requires TypeScript 4.5+.
https://github.com/Swatinem/rollup-plugin-dts/blob/master/CHANGELOG.md#600
| @@ -25,7 +24,6 @@ export const treeShakingPlugin = ({ | |||
| const bundle = await rollup({ | |||
| input: [info.path], | |||
| plugins: [ | |||
| hashbang(), | |||
There was a problem hiding this comment.
Shebang is preserved by rollup now.
https://rollupjs.org/migration/#:~:text=When%20bundling%20CLI%20apps%2C%20Rollup%20will%20now%20automatically%20preserve%20shebang%20comments%20in%20entry%20files%20if%20the%20output%20format%20is%20es%20or%20cjs.%20Previously%2C%20you%20would%20have%20needed%20to%20add%20the%20comment%20via%20a%20plugin.
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I think the minor is good. Rollup is used internally in tsup, and didn't exposed for tsup user. |
|
Upgrading rollup itself is not a breaking change. But this PR upgrades the minimum supported Node.js version and bumps peerDep TypeScript version. Both of them are breaking changes. |
|
Oh you're right. |
