refactor: replace globby attempt 2
#1167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
|
turned it into its own library, will send another PR |
|
superseded by #1168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the followup pr mentioned in #1163. i've opened this mainly to get feedback from the maintainers on the best way to implement this. i can port the globbing code into its own package if needed, even though this isn't that much code
according to globby's readme the only exclusive features it has (that are relevant in this case) are negated patterns and directory expansion, which this pr both covers
the issues reported in 6.2.1 were all related to either me forgetting to handle negated patterns in
entryor not knowing directory expansion was meant to be done. if there is any more globby-exclusive functionality missing let me know and i'll add iti'd be happy to test any possible edge cases in the logic and add new tests
ref: #1163 (comment)