Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup testing environment and reproducible build #26

Merged
merged 22 commits into from
May 16, 2024
Merged

test: setup testing environment and reproducible build #26

merged 22 commits into from
May 16, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented May 15, 2024 •
edited
Loading

#10

  • Adds reproducible builds, so everyone in the team has the same testing environment.
  • Configures 1-liner, so everyone can spawn validators + collator (zombienet) by using just testnet.

@th7nder th7nder changed the base branch from main to develop May 15, 2024 14:18
@th7nder th7nder changed the title feat/10/testing environment Setup testing environment and reproducible build (#10) May 15, 2024
@th7nder th7nder changed the title Setup testing environment and reproducible build (#10) test: setup testing environment and reproducible build (#10) May 15, 2024
@th7nder th7nder changed the title test: setup testing environment and reproducible build (#10) test: setup testing environment and reproducible build May 15, 2024
@th7nder th7nder force-pushed the feat/10/testing-environment branch from 7d48422 to 35925ee Compare May 15, 2024 14:41
@th7nder
Copy link
Contributor Author

th7nder commented May 15, 2024

Resolves: #9 as well.

This was linked to issues May 15, 2024
Testing environment setup #10
Closed
Replace Polkadot Launch with Zombienet #9
Closed
@th7nder th7nder self-assigned this May 15, 2024
@th7nder th7nder added the ready for review Review is needed label May 15, 2024
aidan46
aidan46 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for setting this up 🙏. Tested this on my Linux machine and it worked great. I'll try on macos too

aidan46
aidan46 previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on macos and works there too 👍

jmg-duarte
jmg-duarte requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I guess I'm gonna start taking nix for a spin in my personal projects too.

I left some questions, nitpicks and one change request (the taplo one)

DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
scripts/local-testnet.toml Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
rust-toolchain.toml Show resolved Hide resolved
Justfile Show resolved Hide resolved
.taplo.toml Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
@th7nder th7nder requested review from jmg-duarte and aidan46 May 16, 2024 09:24
jmg-duarte

This comment was marked as outdated.

Sign in to view

@th7nder th7nder requested a review from jmg-duarte May 16, 2024 09:45
jmg-duarte
jmg-duarte approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cernicc
Copy link
Member

cernicc commented May 16, 2024

I see nix, I like :D

serg-temchenko
serg-temchenko approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@serg-temchenko serg-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for this life improvement setup! 🔥

@serg-temchenko serg-temchenko merged commit 63f2846 into develop May 16, 2024
2 checks passed
@serg-temchenko serg-temchenko deleted the feat/10/testing-environment branch May 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serg-temchenko serg-temchenko serg-temchenko approved these changes

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@aidan46 aidan46 Awaiting requested review from aidan46

Assignees

@th7nder th7nder

Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing environment setup Replace Polkadot Launch with Zombienet
5 participants
@th7nder @cernicc @serg-temchenko @jmg-duarte @aidan46