-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add taplo CI #4
Conversation
`taplo lint` and `taplo format`, in that order, have been add on push and pull request into any branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left an idea to consider
Add a configuration file for taplo so CI and local can use the same taplo rules.
Switch from Action for taplo CI to manual install and running. Use only `taplo format` and remove `taplo lint` check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but some points should be discussed. Thank you!
This can be controlled using
It doesn't work this way for the preparation steps and dependencies. The "work unit" in GitHub Actions is the job, which gets picked up by runners, whether they are in the same workflow or not it doesn't matter, you'll still need to always set them up with extra dependencies unless you're running self-hosted runners. I agree with the context and cache point though, especially because GitHub doesn't have a good way to orchestrate multiple workflows, but keep in mind that a big CI pipeline may work against us in terms of time spent. Regardless, we can always change it as the project evolves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I set the target branch to |
This makes sense to me because there's a single tracking issue, once the other branch gets merged that works out. But it will depend on how linear you guys want the history to be. Personally, I prefer linear histories (to the point that I prefer rebase over merge for my projects) |
I was going through the GitFlow and didn't see any recommendations for this at a glance (we use this model apparently). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for PR #5 to be merged first so that we have a clean diff.
The base branch was changed.
Description
taplo lint
andtaplo format
, in that order, have been add on push and pull request into any branch. Part of #3