Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polka-storage-provider-server): prove commit #502

Merged
merged 19 commits into from
Nov 7, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Nov 4, 2024

Description

Fixes #394. This PR basically connects all of the remainings docs for P2.
After this one, data is being proven with PoRep.

$ polka-storage-provider-client proofs generate-porep-params
[..]
$ just testnet
[..] set PoRep verifying key from `2KiB.porep.vk.scale via polkadot.js pallet-proofs.set_porep_verifyingkey
[...] wait till block 81 *randomness*
$ examples/rpc_publish.sh examples/random1024.piece
2024-11-05T12:37:39.058348Z  INFO prove_commit: polka_storage_provider_server::pipeline: Successfully proven sectors on-chain: [SectorsProven { owner: AccountId32([144, 181, 171, 32, 92, 105, 116, 201, 234, 132, 27, 230, 136, 134, 70, 51, 220, 156, 168, 163, 87, 132, 62, 234, 207, 35, 20, 100, 153, 101, 254, 34]), sectors: BoundedVec([ProveCommitResult { sector_number: 1, partition_number: 0, deadline_idx: 0 }]) }]
2024-11-05T12:37:39.058452Z  INFO polka_storage_provider_server::pipeline: ProveCommit for sector 1 finished successfully.

Important points for reviewers

There are lots of parts moving here. When trying it out locally, follow the description instruction.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder force-pushed the feat/394/prove-commit-pipeline branch from b2c0171 to 382ddcf Compare November 5, 2024 09:42
@th7nder th7nder self-assigned this Nov 5, 2024
@th7nder th7nder added the pallet-storage-provider Relates to the Storage Provider Pallet label Nov 5, 2024
@th7nder th7nder requested review from aidan46, cernicc and jmg-duarte and removed request for aidan46 and jmg-duarte November 5, 2024 13:32
@th7nder th7nder marked this pull request as ready for review November 5, 2024 13:32
@th7nder th7nder added this to the Phase 2 milestone Nov 5, 2024
@th7nder th7nder mentioned this pull request Nov 5, 2024
7 tasks
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's some small polish needed and I left a comment on the sector state management in the pipeline/mod.rs

Good job!

lib/polka-storage-proofs/src/porep/sealer.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/main.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/types.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/mod.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/mod.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/mod.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/server/src/pipeline/mod.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/394/prove-commit-pipeline branch from 679362b to 6042593 Compare November 5, 2024 23:32
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. I haven't completed the pipeline/mod.rs because I think it's still in progress :D

@th7nder th7nder requested review from cernicc and jmg-duarte November 6, 2024 14:15
@th7nder th7nder added the ready for review Review is needed label Nov 6, 2024
@th7nder th7nder requested a review from aidan46 November 6, 2024 14:55
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Nov 6, 2024
jmg-duarte
jmg-duarte previously approved these changes Nov 6, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@th7nder th7nder added ready for review Review is needed node-storage-provider Related to the storage provider node. and removed ready for review Review is needed labels Nov 7, 2024
@jmg-duarte jmg-duarte enabled auto-merge (squash) November 7, 2024 10:09
@jmg-duarte jmg-duarte merged commit 483959a into develop Nov 7, 2024
10 of 15 checks passed
@jmg-duarte jmg-duarte deleted the feat/394/prove-commit-pipeline branch November 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-storage-provider Related to the storage provider node. pallet-storage-provider Relates to the Storage Provider Pallet ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Proof for Replica + CommR + CommD
4 participants