-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(polka-storage-provider-server): prove commit #502
Conversation
b2c0171
to
382ddcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's some small polish needed and I left a comment on the sector state management in the pipeline/mod.rs
Good job!
679362b
to
6042593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I haven't completed the pipeline/mod.rs because I think it's still in progress :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
Description
Fixes #394. This PR basically connects all of the remainings docs for P2.
After this one, data is being proven with PoRep.
Important points for reviewers
There are lots of parts moving here. When trying it out locally, follow the description instruction.
Checklist