feat: interface and data structures for Collator Power Pallet #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
reviewed
May 29, 2024
th7nder
commented
May 29, 2024
aidan46
reviewed
May 30, 2024
aidan46
reviewed
May 30, 2024
aidan46
reviewed
May 30, 2024
aidan46
reviewed
May 30, 2024
aidan46
reviewed
May 30, 2024
8 tasks
serg-temchenko
suggested changes
May 31, 2024
There was a problem hiding this comment.
I'd suggest to revisit this section to rewind the logic and how it matches with logic defined here, in this pr. Plus take a look into the power actor and after that maybe discuss more the approach before the implementation. I think some my comments here should bright some light as well.
asmie
requested changes
Jun 3, 2024
| @@ -0,0 +1,97 @@ | |||
| # Overall Power Pallet Flow | |||
|
|
|||
| ## Glossary | |||
There was a problem hiding this comment.
Since we are using mono repo for our work, the glossary could be made in a separate, higher-level document to keep terminology consistent across the project.
|
This has been descoped because of the #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take a look at the
DESIGN.mdfile, it's all in there.Important points for reviewers
This is first of many PRs of the implementation for #18 .
Here I wanted to give an overall idea, without tests, benchmarks and so on.
Basically DESIGN = ideas + interfaces + data structures.