chore: Replace static str errors #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
force-pushed
the
chore/replace-str-errors
branch
from
b849002 to
66e26ab
Compare
jmg-duarte
reviewed
Nov 26, 2024
I thought the same thing, but after running generate-scale against the testnet, no changes to the SCALE file. I think this is because these errors are not used in pallets (yet) |
aidan46
added
ready for review
th7nder
approved these changes
Nov 26, 2024
jmg-duarte
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I was refactoring the errors for the market pallet, I noticed there we some
Result's that returned a static str as the error. This small change adds proper errors for those. static str's cannot be returned as errors in pallet, this future-proofs the error were we to use them in pallets.