Skip to content

Commit

Permalink
Benchmarks: Remove base-compat dependency
Browse files Browse the repository at this point in the history
The `plated` benchmark suite previously had a dependency on `base-compat`,
which was introduced in #909 for compatibility with pre-7.10 versions of GHC.
In #977, however, the minimum version of GHC was raised to 8.0, which means
that there is no longer any reason for these benchmarks to depend on
`base-compat`. This patch removes the dependency.
  • Loading branch information
RyanGlScott committed Apr 30, 2024
1 parent a713e77 commit 4d5df4b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
7 changes: 0 additions & 7 deletions benchmarks/plated.hs
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@
{-# OPTIONS_GHC -funbox-strict-fields #-}
module Main (main) where

#ifndef MIN_VERSION_base
#define MIN_VERSION_base(x,y,z) 1
#endif

import Prelude ()
import Prelude.Compat

import Control.Lens
import Control.DeepSeq
import Criterion.Main
Expand Down
1 change: 0 additions & 1 deletion lens.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ benchmark plated
default-language: Haskell2010
build-depends:
base,
base-compat >=0.11.0 && <0.15,
comonad,
criterion,
deepseq,
Expand Down

0 comments on commit 4d5df4b

Please sign in to comment.