-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prisms for working with prefixed and suffixed text #982
Conversation
@Taneb, is this something you're planning to work on soon? I'm interested in landing this before the next |
I'd forgotten about it, being honest. My main issue was I couldn't figure out how to run the doctests locally, so I'd have had to do a lot of noisy trial and error to get things passing. Other than that I'm happy to work on it. I think the branch is on this repo so anyone with permission for ekmett/lens should be able to push to it |
My apologies, I didn't realize you were blocked. Here is my workflow for running the doctests:
If that doesn't work, feel free to shout. |
I pushed a commit which fixes the build errors on old GHCs. Or so I thought, at least. There's a separate issue on GHC 7.8.4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI finally passes. Hooray!
I've pushed some commits which add more Haddocks, more changelog descriptions, and makes things more backwards-compatible. I think that takes care of the remaining review suggestions, so unless anyone notices something I've overlooked, I'll plan to merge this within a day or so. |
Closes #981