Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add documentation from todo proposal PR #10

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Aug 22, 2024

documentation update as specified in #9

resolves #9

@MangoIV MangoIV mentioned this pull request Aug 22, 2024
@MangoIV
Copy link
Contributor Author

MangoIV commented Aug 22, 2024

I have changed the module name in the Exception in the documentation but have refrained to put a stacktrace as produced by this package as this might be different on different GHC versions and only clutters the documentation.

@MangoIV
Copy link
Contributor Author

MangoIV commented Aug 22, 2024

Ah line numbers have changed. I’ll adjust

@MangoIV MangoIV force-pushed the mangoiv/documentation-update branch from 25d33f1 to da287ea Compare August 22, 2024 19:38
@MangoIV
Copy link
Contributor Author

MangoIV commented Aug 22, 2024

i've also taken the freedom to test with newest ghc and bump the minor versions

@MangoIV
Copy link
Contributor Author

MangoIV commented Aug 25, 2024

rendered:

image

@tomjaguarpaw
Copy link

Looks really nice. @ekmett, thoughts?

@ekmett ekmett merged commit cae8fe7 into ekmett:main Aug 31, 2024
13 checks passed
@ekmett
Copy link
Owner

ekmett commented Aug 31, 2024

Merging. Will release at ICFP when I have some downtime.

@MangoIV
Copy link
Contributor Author

MangoIV commented Aug 31, 2024

Thank you so much!

@tomjaguarpaw
Copy link

Seconding the thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hackage release
3 participants